Update default behavior of uncontrolled table to only update page on rows change if the user is outside of the page bounds #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gregbaroni
commented
Oct 18, 2023
•
gregbaroni
commented
- Rather than having a prop for if the page should be reset when the rows change, the default behavior will be to only update the page if the user is out of bounds when the rows change
- This also fixes a bug with the resetPageOnRowChange prop where, if this was false and the user was on the last page, then it would be possible for the user. to be outside of the page bounds if rows were removed
gregbaroni
force-pushed
the
snoop-fix-reset-page-on-row-change-bug
branch
2 times, most recently
from
a1ba81c to
fd6d753
Compare
gregbaroni
changed the title
…is out of bounds - Rather than having a prop for if the page should be reset when the rows change, the default behavior will be to only update the page if the user is out of bounds when the rows change - This also fixes a bug with the resetPageOnRowChange prop where, if this was false and the user was on the last page, then it would be possible for the user to be outside of the page bounds if rows were removed
gregbaroni
force-pushed
the
snoop-fix-reset-page-on-row-change-bug
branch
from
fd6d753 to
aee28d0
Compare
|
Released prerelease version |
JeremyRH
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.